use readerfrom optimization by forking Go reverseproxy #251
harshavardhana
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
Annotations
10 errors and 1 warning
|
Test on Go 1.20.x and ubuntu-latest:
reverse/proxy.go#L230
empty-block: this block is empty, you can remove it (revive)
|
|
Test on Go 1.20.x and ubuntu-latest:
reverse/proxy.go#L190
unused-parameter: parameter 'req' seems to be unused, consider removing or renaming it as _ (revive)
|
|
Test on Go 1.20.x and ubuntu-latest:
reverse/proxy_test.go#L792
unused-parameter: parameter 'r' seems to be unused, consider removing or renaming it as _ (revive)
|
|
Test on Go 1.20.x and ubuntu-latest:
http-tracer.go#L118
exported: exported method ResponseWriter.ReadFrom should have comment or be unexported (revive)
|
|
Test on Go 1.20.x and ubuntu-latest:
reverse/proxy_test.go#L1333
const `content` is unused (unused)
|
|
Test on Go 1.20.x and ubuntu-latest:
http-tracer.go#L90
field `readerFrom` is unused (unused)
|
|
Test on Go 1.20.x and ubuntu-latest:
reverse/proxy.go#L241
SA1019: http.CloseNotifier has been deprecated since Go 1.11 and an alternative has been available since Go 1.7: the CloseNotifier interface predates Go's context package. New code should use Request.Context instead. (staticcheck)
|
|
Test on Go 1.20.x and ubuntu-latest:
reverse/proxy_test.go#L420
SA1019: http.CloseNotifier has been deprecated since Go 1.11 and an alternative has been available since Go 1.7: the CloseNotifier interface predates Go's context package. New code should use Request.Context instead. (staticcheck)
|
|
Test on Go 1.20.x and ubuntu-latest:
reverse/proxy_test.go#L446
SA1019: frontendClient.Transport.(*http.Transport).CancelRequest has been deprecated since Go 1.6 and an alternative has been available since Go 1.5: Use Request.WithContext to create a request with a cancelable context instead. CancelRequest cannot cancel HTTP/2 requests. (staticcheck)
|
|
Test on Go 1.20.x and ubuntu-latest
Process completed with exit code 1.
|
|
Test on Go 1.20.x and ubuntu-latest
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-go@v2, actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|