-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optimistic mode #123
Add optimistic mode #123
Conversation
5209903
to
b7dcc21
Compare
Reviewing tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor stuff.
Agree this is a weird location to have it, but not a major pain point.
@harshavardhana Sorry, I was still working on the changes proposed by @klauspost. They were already committed to this branch, but I was in the process of testing them. |
@ramondeklein What's the worry then :D |
Everything checks out okay. I made the following changes:
Code looks a bit cleaner this way. I did test both optimistic and regular modes. |
This PR adds the
--optimistic
flag that reduces the amount of health-checks significantly. It works like this:There are two advantages to this approach:
The major disadvantages are:
I would like to hear your comments...