Fix for incorrect row removal with function #223
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When more than one row was removed, sometimes the wrong row would be removed due to the direction of removal (first to last rather than last to first).
|
👋🏻 from 2021! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When more than one row was removed, sometimes the wrong row would be removed due to the direction of removal (first to last rather than last to first).
This is related to #210, but that solution involved reversing the array of rows to remove, which doesn't seem very performant. This solution
unshifts the row indices so they're in the right order to begin with. I wrote a similar corresponding test which fails without this fix.