-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using SCSS/LESS instead of CSS #37
base: master
Are you sure you want to change the base?
Conversation
I think a value addition to this would be linting for the LESS with either Lesshint (personal fav) or Stylelint. |
Thanks for this. Initial check looks good. Will look at it a little soon! |
@misterGF let me know how it goes! |
Hey @vpiskunov. I'm on it this week! I added a bad commit in your PR while attempting to fix some dependency changes since you submitted. Could you remove it? I also tested your fork and get this error. Thoughts? |
Hey @misterGF ! Good to hear, Can you locate the .less files manually in that branch checked out? If so, let me know at which path they are placed. |
Still in progress? |
Yes, I haven't heard about any updates. @vpiskunov. Have you had a chance to look at this? |
@misterGF Hi, I asked you on your previous comment - haven't heard your feedback on:
That's kind of crucial for me to understand where the errors could arise from - it worked in my environment. So let me know. |
Is development on this still active? |
I thought @misterGF had merged this long time back? Also seems theres been a lot of changes since my initial pull request, so unless it was merged, might be easier to re-implement than fix. |
@vpiskunov. Could never get it to properly build. I’m still interested in getting this merged. If you could re-implement I can make it a priority to get this merged. |
Added AdminLTE LESS files, and integrated them into the Webpack config to include LESS in the build process. Let me know if you have any thoughts for improvements, or if I've missed out on anything.
Included are the skin files as well, with the blue skin used by default - to change this, simply replace with respective colour named file in 'build/webpack.base.conf.js'
This is in response to the earlier issue: #19 - as per @misterGF 's comment, here is the PR.
P.S. I see you've closed the issue earlier after euvl's commit - his commits did not tackle the full LESS support - but rather only partial modules being rewritten into SASS.