Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak in SimplePaletteItem #3202

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix memory leak in SimplePaletteItem #3202

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../appengine/src/com/google/appinventor/client/editor/simple/palette/SimplePaletteItem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ public MockComponent createMockComponent() {
cacheInternalComponentPrototype();

MockComponent returnedComponentPrototype = componentPrototype;
componentPrototype = null;
// componentPrototype = null;
Copy link
Member Author

@barreeeiroo barreeeiroo Jul 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this code does not 100% work (it stops creating some new instances), but just sharing it as something's off with the actual component instantiation. 🙂
Every time a component gets dragged and dropped, two instances are created but just one fires its delete.

return returnedComponentPrototype;
}

Expand Down