Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Markdown #76

Open
daKmoR opened this issue Mar 20, 2020 · 2 comments
Open

Support for Markdown #76

daKmoR opened this issue Mar 20, 2020 · 2 comments

Comments

@daKmoR
Copy link

daKmoR commented Mar 20, 2020

hey there 👋

it would be awesome if the html highlighting would work for js blocks inside markdown as well.
Here is the use case that we are after - Screenshot from VS Code

Screenshot 2020-02-03 at 21 44 06

would be awesome if that is highlighted 👍

any chance we can get some pointers on where to start looking to get this supported? e.g. we can contribute but we probably need a little help to get started 🤗

@daKmoR
Copy link
Author

daKmoR commented Mar 20, 2020

answer by @mjbvz here

Yes, please submit a PR. The fix is to update the injection selectors for the grammar to also target html in markdown files

@rubensa
Copy link

rubensa commented Apr 11, 2023

@mjbvz Should this enable HTML syntax highlighting and validation for HTML tags inside any markdown part (not only inside code blocks)? 😕

We use:

    <details>
    <summary></summary>
    </details>

HTML tags pattern in many GitHub md files but, as HTML syntax is not validated inside md files, people tends to forget the closing details tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants