feat: mermaid zoom & pan #247
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please get this merged! Important feature for big diagrams |
|
Can we get this pulled in? |
|
We are waiting for this as well, can't read any of our diagrams anymore! |
mjbvz
requested changes
Apr 30, 2024
There was a problem hiding this comment.
Thanks for taking a look but this needs more thought and testing
Some initial things noticed from a quick test:
-
The diagram now occupies more space. This is annoying for correctly sized diagrams
-
You can end up zooming the diagram instead of scrolling. Maybe there should be an explicit button to start panning / zoom?
-
Zoom/pan gets reset everytime the markdown is updated
-
After zooming/panning you can end up with the diagram being cropped in weird ways
|
Closing because this hasn't seen recent activity and can't be merged in its current state |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for panning and zooming in the mermaid MD preview window
Closes #125