Merge pull request #15 from davel/make_happy

Fix bug in test code picked up by -fanalyzer and update compilers
mjwoodcock · Jan 29, 2024 · 0571dfb · 0571dfb
2 parents a2303e5 + 81ca73d
commit 0571dfb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/.github/workflows/actions.yml b/.github/workflows/actions.yml
@@ -5,7 +5,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        os: ['ubuntu-latest', 'macos-latest', 'ubuntu-18.04']
+        os: ['ubuntu-latest', 'macos-latest', 'ubuntu-20.04']
         cc: [ 'gcc', 'clang' ]
     name: Compile on ${{ matrix.os }} using ${{ matrix.cc }}
     env:
@@ -23,8 +23,8 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        os: ['ubuntu-20.04']
-        cc: [ 'gcc-10']
+        os: ['ubuntu-22.04']
+        cc: [ 'gcc-12']
     name: Run static analyzer ${{ matrix.cc }}
     env:
       CFLAGS: '-Wall -Wextra -Werror -fanalyzer'

diff --git a/testprog/pack.c b/testprog/pack.c
@@ -46,6 +46,7 @@ main(int argc, char *argv[])
 	if (!out)
 	{
 		error("Failed to open %s for writing", argv[3]);
+		exit(1);
 	}
 
 	if (strcmp(argv[1], "-p") == 0)