Update Team object with improved team name mapping

mkreiser · Oct 21, 2023 · 1b63e4a · 1b63e4a
1 parent c6d4ee9
commit 1b63e4a
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 19 deletions.
diff --git a/src/team/team.js b/src/team/team.js
@@ -85,10 +85,7 @@ class Team extends BaseCacheableObject {
   static responseMap = {
     id: 'id',
     abbreviation: 'abbrev',
-    name: {
-      key: 'location',
-      manualParse: (responseData, data) => `${_.trim(data.location)} ${_.trim(data.nickname)}`
-    },
+    name: 'name',
     logoURL: 'logo',
     wavierRank: 'wavierRank',
 

diff --git a/src/team/team.test.js b/src/team/team.test.js
@@ -42,21 +42,6 @@ describe('Team', () => {
   describe('responseMap', () => {
     const buildTeam = (data, options) => Team.buildFromServer(data, options);
 
-    describe('name', () => {
-      describe('manualParse', () => {
-        test('interpolates location and nickname into a single string', () => {
-          const data = {
-            location: ' First ',
-            nickname: ' Last ',
-            name: 'This is not used'
-          };
-          const team = buildTeam(data);
-
-          expect(team.name).toBe(`${_.trim(data.location)} ${_.trim(data.nickname)}`);
-        });
-      });
-    });
-
     describe('roster', () => {
       describe('manualParse', () => {
         test('returns an array of players', () => {