Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw errors when invalid season IDs are passed to Client methods #235

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

mkreiser
Copy link
Owner

Man there's a lot of code I need to clean up famous_last_words.png

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1196a72) 100.00% compared to head (b5f2fee) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #235   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          253       266   +13     
  Branches        39        43    +4     
=========================================
+ Hits           253       266   +13     
Files Coverage Δ
src/client/client.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkreiser mkreiser merged commit af6f441 into main Oct 23, 2023
20 checks passed
@mkreiser mkreiser deleted the errors branch October 23, 2023 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant