Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap js in DOMContentLoaded listener to prevent $.ui from being undefined #206

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ErwinJunge
Copy link

I had a problem after upgrading to django 2.2 that $.ui was undefined on my admin pages and selectable stopped working, even though both jquery and jqueryui were still in the head (we use the base_site.html override with include_ui_theme and include_jquery_libs).

It's a bit hard to see from the diff, but essentially the fix comes down to wrapping the js in

document.addEventListener("DOMContentLoaded", function() {
   // js goes here
});

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant