Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate parameters that don't exist in schema.org. #479

Merged
merged 5 commits into from
Feb 5, 2024

Conversation

marcenacp
Copy link
Contributor

No description provided.

@marcenacp marcenacp requested a review from a team as a code owner February 5, 2024 10:10
Copy link

github-actions bot commented Feb 5, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

from mlcroissant._src.core.rdf import Rdf


def test_shorten_value():
rdf = Rdf.from_json(
ctx=Context(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to add a test for when ctx is not empty?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thanks!

Copy link
Contributor

@ccl-core ccl-core left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pierre!

@marcenacp marcenacp force-pushed the feature/spec-changes-3 branch from a708acb to 67da972 Compare February 5, 2024 13:06
@marcenacp marcenacp merged commit 256f4eb into main Feb 5, 2024
@marcenacp marcenacp deleted the feature/spec-changes-3 branch February 5, 2024 13:41
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants