Fix dev container problems #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
marcenacp
reviewed
Feb 6, 2024
| # Install dev packages. | ||
| pip3 install python/mlcroissant/.[dev] | ||
| # Install dependencies except mlcroissant itself | ||
| pip install absl-py \ |
There was a problem hiding this comment.
Not possible to do something like pip install .[dev]? (No idea, would just be easier to maintain)
marcenacp
reviewed
Feb 6, 2024
python/mlcroissant/pyproject.toml
Outdated
| "mlcroissant[git]", | ||
| "mlcroissant[image]", | ||
| "mlcroissant[parquet]", | ||
| ] | ||
| devdeps = [ |
There was a problem hiding this comment.
Why do you need to distinguish between dev and devdeps and what distinction do you make?
There was a problem hiding this comment.
Reverted the file, changes not needed if needed deps listed in postCreateCommand :)
marcenacp
approved these changes
Feb 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.