Add isLiveDataset field
#494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
|
Addresses #495 |
Manually correct formatting
Manually fix formatting
Manually fix file
Fix manually file
marcenacp
approved these changes
Feb 7, 2024
| ctx = self.node.ctx | ||
| # For live datasets, we do not raise an error if the hashes checks fail, but | ||
| # only the warning above. | ||
| if ctx.is_live_dataset: |
There was a problem hiding this comment.
Can you add a unit test in download_test.py? Something like:
@pytest.mark.parametrize("conforms_to", CroissantVersion)
# Test the hex and base64 hash values
def test_hashes_are_not_checked_for_live_datasets(conforms_to):
with tempfile.NamedTemporaryFile(delete=False) as f:
filepath = f.name
ctx = Context(conforms_to=conforms_to, is_live_dataset=True)
metadata = Metadata(ctx=ctx, name="bar")
file_object = create_test_file_object(
name="foo",
content_url=os.fspath(filepath),
)
file_object.parents = [metadata]
download = Download(operations=operations(), node=file_object)
download()
| # only the warning above. | ||
| if ctx.is_live_dataset: | ||
| return | ||
| # In v0.8 only, hashes were not checked. |
There was a problem hiding this comment.
Instead of the comment, use not ctx.is_v0()? (Probably this line is anterior to the creation of the function)
There was a problem hiding this comment.
Yes, I just moved the pre-existing line below. I think ctx.is_v0() would do the same.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.