Login with trakt and sync history in movies #24
Conversation
# Conflicts: # data/trakt-auth/src/main/java/io/filmtime/data/trakt/auth/TraktAuthRepository.kt
# Conflicts: # build.gradle.kts # feature/movie-detail/src/main/java/io/filmtime/feature/movie/detail/MovieDetailScreen.kt # gradle/libs.versions.toml
|
Dear @hadi-norouzi, just wanted to say a big thanks for the awesome pull request you dropped in this repo. It's clear you've put a lot of effort into it, and it really stands out. Can't wait to dig into the details! Currently, I have some urgent commitments to attend to this week, which means I won't be able to get to your PR right away. However, I want to assure you that your PR is a priority for me, and I plan to allocate dedicated time for a review as soon as possible. I expect to be able to do this by the end of next week. Thanks again for your hard work and dedication to the project. Your contributions are really valuable to me. |
It's my pleasure to work with you and I hope to be more valuable to this project. |
There was a problem hiding this comment.
Dear @hadi-norouzi
I just wanted to say I'm really sorry for getting to your PR so late. I know you put effort into this, and it wasn't cool to keep you waiting. Thanks for your patience.
Currently, you might not be in the mood to revise and update the existing PR, so I kindly request that you simply create issues where I've noted in the comments. This way, we can enhance the code later based on these new issues.
Best,
Reza
data/api/trakt/src/main/java/io/filmtime/data/api/trakt/TraktAuthRemoteSourceImpl.kt
Show resolved
Hide resolved
data/api/trakt/src/main/java/io/filmtime/data/api/trakt/TraktSearchRemoteSourceImpl.kt
Outdated
Show resolved
Hide resolved
data/api/trakt/src/main/java/io/filmtime/data/api/trakt/TraktSearchRemoteSourceImpl.kt
Outdated
Show resolved
Hide resolved
| // TODO: move check token in a function | ||
| traktAuthLocalSource.tokens.firstOrNull() ?: return Result.Failure(GeneralError.ApiError("Unauthorized", 401)) | ||
| val result = traktSyncService.getWatchedHistory( | ||
| type = "movies", | ||
| accessToken = "", | ||
| ) |
There was a problem hiding this comment.
Please create another issue for extracting this code as a new function
|
|
||
| videoDetail.isWatched?.let { | ||
| when (it) { | ||
| true -> OutlinedButton(onClick = {}) { |
There was a problem hiding this comment.
Create an issue for handling this onClick here
| val traktId = _state.value.videoDetail?.ids?.traktId ?: return@launch | ||
| val result = traktHistoryRepository.addToHistory(traktId.toString()) | ||
| when (result) { | ||
| is Failure -> TODO() |
There was a problem hiding this comment.
Create an issue for handling this TODO
feature/trakt-login/src/main/java/io/filmtime/feature/trakt/login/TraktLoginViewModel.kt
Outdated
Show resolved
Hide resolved
feature/trakt-login/src/main/java/io/filmtime/feature/trakt/login/TraktLoginWebView.kt
Outdated
Show resolved
Hide resolved
feature/trakt-login/src/main/java/io/filmtime/feature/trakt/login/TraktLoginWebView.kt
Show resolved
Hide resolved
# Conflicts: # data/network/src/main/java/io/filmtime/data/network/NetworkModule.kt
I've no problem at all. I've just waiting for your youtube videos 😄. |
|
@hadi-norouzi, could you kindly reach out to me via Telegram (@moallemi) or Discord to discuss a few matters? |
I've implemented these features:
if you have any feedback, I would be happy to hear it.
#16