Skip to content

NonZero (unchecked_mul & unchecked_add) Proof for Contracts #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 44 commits into
base: main
Choose a base branch
from

Conversation

tautschnig
Copy link
Member

Towards #71

These are the changes contributed by SahithiMV in #184 plus the proposed changes in that PR.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

aa-luna and others added 25 commits September 20, 2024 14:38
Added contract and placeholder harness
Corrected issues from Pull Request
Restored previous cargo files
@tautschnig tautschnig removed their assignment Apr 24, 2025
@carolynzech carolynzech marked this pull request as draft May 8, 2025 15:33
@carolynzech
Copy link

Draft for now; needs a subtree update to pass CI. It could still technically be reviewed before that, but I think it's better to save the second review for when things are passing and we can sanity-check that we are indeed proving the right thing with the new Kani version.

@tautschnig tautschnig marked this pull request as ready for review May 20, 2025 17:17
};
}

macro_rules! check_mul_unchecked_intervals {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am curious how this interval trick works for 16 and 32-bit int types (without smt backend?), and how did you pick those interval? Could you please add some comments here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants