Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugging page: adjust one-liner to create developer_settings.json file if necessary #111

Conversation

jamiew
Copy link
Contributor

@jamiew jamiew commented Jan 15, 2025

A stock install of Claude Desktop doesn't seem to have a developer_settings.json file, so the setup instructions for Chrome Dev Tools on the Debugging are incomplete.

This adjusts

Motivation and Context

See above. Note this does not fix the unspoken dependency on jq, and like a lot of things in the docs, is currently Mac-specific

How Has This Been Tested?

I'm on a Mac with jq. I've tested it with the file missing, the file present w/ my own changes, and the file present but empty

Breaking Changes

Nothing

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Love MCP so far, keep up the great work, will keep the docs PRs coming if welcome :)

Expands the one-liner on the Debugging page. That file does not
seem to be present on a stock Claude Desktop installation.
@jamiew jamiew force-pushed the debugging-create-dev-settings-file-if-needed branch from 5cd7c2f to 5841488 Compare January 15, 2025 16:38
Copy link
Member

@jspahrsummers jspahrsummers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the correction!

Since this has made the command balloon in complexity, and we have a possibly-undesirable dependency on jq, what do you think about just writing:

{ "allowDevTools": true }

… to the file in its entirety? It should be fine to overwrite the file if it exists.

@jamiew
Copy link
Contributor Author

jamiew commented Jan 22, 2025

@jspahrsummers that would be much better. I assumed there was an important reason why the existing code was rewriting this file, despite it not even existing by default

@jamiew jamiew requested a review from jspahrsummers January 22, 2025 16:33
While I'm paying attention. Squash merges ftw
Copy link
Member

@jspahrsummers jspahrsummers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@jspahrsummers jspahrsummers merged commit 558de7a into modelcontextprotocol:main Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants