-
Notifications
You must be signed in to change notification settings - Fork 435
Add e2e tests #354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
olaservo
wants to merge
30
commits into
modelcontextprotocol:main
Choose a base branch
from
olaservo:add-integration-tests-take-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add e2e tests #354
olaservo
wants to merge
30
commits into
modelcontextprotocol:main
from
olaservo:add-integration-tests-take-2
+3,354
−210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…move console log collection for now
olaservo
commented
Apr 28, 2025
olaservo
commented
Apr 28, 2025
@@ -49,21 +58,28 @@ | |||
"zod": "^3.23.8" | |||
}, | |||
"devDependencies": { | |||
"@modelcontextprotocol/server-everything": "2025.4.25", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of these dependency updates are probably from a previous attempt on same branch - main ones to pay attention to are importing server-everything and adding Playwright to dev dependences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Opening as a draft for feedback on this general approach. There's a few configs that need to get adjusted or cleaned up here and obviously the oauth part is still mostly
// TODO
.Will plan to update to include Streamable Http once we can import the latest changes from the published package.
How Has This Been Tested?
To run these tests I've been doing the following:
In one terminal, run Inspector locally
In another terminal, run one of the transport-specific test commands, eg:
Breaking Changes
None
Types of changes
Checklist