fix: preserve auth server path in OAuth metadata URL construction #521
+53
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the path was stripped when constructing the well-known OAuth metadata URL. Per RFC 8414 §3.1, the path must be preserved after the .well-known segment to support multitenant auth servers that encode tenant IDs in the path. - Fix oauthAuthServerMetadataUrl to preserve path segments - Add comprehensive test coverage for the function
dankelleher
force-pushed
the
fix/issue-520-oauth-authorization-server-path
branch
from
52c9668 to
846f67d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the path was stripped when constructing the well-known OAuth metadata URL. Per RFC 8414 §3.1, the path must be preserved after the .well-known segment to support multitenant auth servers that encode tenant IDs in the path.
Fixes issue #520
Motivation and Context
The current solution brings challenges for multitenant auth servers
How Has This Been Tested?
I tested a local deployment of the inspector with this change hacked in and it solved the issue.
Breaking Changes
No
Types of changes
Checklist
Additional context