-
Notifications
You must be signed in to change notification settings - Fork 556
[auth] Add resource compatibility to debugger (RFC 8707) #526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pcarleton
wants to merge
9
commits into
main
Choose a base branch
from
pcarleton/auth-debugger-resource
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+37
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
ochafik
previously approved these changes
Jun 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg, just tinits :-)
4 tasks
ptal? @ochafik once we bump the typescript version for modelcontextprotocol/typescript-sdk#664 we can merge in https://github.com/modelcontextprotocol/inspector/pull/537/files to use the SDK function rather than having slightly bespoke logic here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
We've added RFC 8707 Resource Indicators as part of the MCP spec. There is an inflight change to add this to the Typescript SDK.
This change adds the similar behavior to the inspector in order to facilitate debugging.
This depends on: modelcontextprotocol/typescript-sdk#638
How Has This Been Tested?
Tested against the typescript SDK example server, and also tested against a few live servers (sentry, jira) to make sure it doesn't break.
Breaking Changes
Previously, we didn't care about the
resource
parameter returned in the Protected Resource Metadata. Now, in the debugger (and in the regular flow), we'll throw an exception if the resource does not match the provided server url.Another potential breakage is if an AS rejects the
resource
parameter as invalid, we won't progress through the authorization flow, but we think this is unlikely.Types of changes
Checklist
Additional context