fix(client): sendMessage() should fail immediately when connect() fails #323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sendMessage() waits on closeLatch until the message endpoint is ready. However, if the HTTP connection fails during the connect phase, sendMessage() wastes 10 seconds waiting on closeLatch. This commit replaces CountDownLatch with CompletableFuture and calls CompletableFuture.cancel() on connect failure. As a result, sendMessage() now fails immediately instead of waiting for 10 seconds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
sendMessage() waits on closeLatch until the message endpoint is ready.
However, if the HTTP connection fails during the connect phase, sendMessage() wastes 10 seconds waiting on closeLatch.
This commit replaces CountDownLatch with CompletableFuture and calls CompletableFuture.cancel() on connect failure.
As a result, sendMessage() now fails immediately instead of waiting for 10 seconds.
How Has This Been Tested?
Our project’s server uses this SDK to relay MCP communication, and we’ve confirmed that it works well in that environment.
Breaking Changes
Types of changes
Checklist
Additional context