If a handler throws McpError, use its values for the RPC error #465
+82
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @Randgalt . I like this. |
tzolov
requested changes
Aug 7, 2025
| .onErrorResume(t -> { | ||
| McpSchema.JSONRPCResponse.JSONRPCError error; | ||
| if (t instanceof McpError mcpError) { | ||
| error = mcpError.getJsonRpcError(); |
There was a problem hiding this comment.
Until we remove the McpError(Object) constructor we need to check that the getJsonRpcError() is not null otherwise create new JSONRCPError.
Handlers should be able to throw RPC errors and `McpError` is the right exception for that. Improve `DefaultMcpStatelessServerHandler` error handler to check if the exception is `McpError` and, if so, use it to build the RPC error result instead of re-writing as `INTERNAL_ERROR`.
Randgalt
force-pushed
the
jordanz/passthrough-mcp-error
branch
from
b1cc84b to
11ec3e2
Compare
tzolov
approved these changes
Aug 8, 2025
|
back-ported to 0.11.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handlers should be able to throw RPC errors and
McpErroris the right exception for that.Improve
DefaultMcpStatelessServerHandlererror handler to check if the exception isMcpErrorand, if so, use it to build the RPC error result instead of re-writing asINTERNAL_ERROR.Motivation and Context
Handlers will want to send the client errors such as not found, etc. The MCP spec allows for RPC errors to be returned.
How Has This Been Tested?
New test,
testThrownMcpError()inHttpServletStatelessIntegrationTests.Breaking Changes
none
Types of changes
Checklist