Skip to content

Introduce Kotlin client/server <--> TypeScript client/server integration tests #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

skarpovdev
Copy link

@skarpovdev skarpovdev commented Aug 5, 2025

General requirement to run the tests (apart from the main requirements for running any code in the repo) is to have node.js installed. I don't see the need for a separate README.md, but let me know if you think it's needed.

  1. In setupTypeScriptSdk we clone the latest head of TypeScript SDK and instal all the dependencies. I thought about using the released version by installing it with npm, but decided to run tests with the latest commits to help us find issues faster, before the new version is released.
  2. I put edge cases coverage into separate test classes to keep the main integration tests easy to find and debug. Btw, this part is mostly done by Junie.
  3. For TypeScript server I use simpleStreamableHttp from examples. If there is a concern it will be changed and hence such usage better be avoided, it can easily be migrated into a separate file.
  4. Kotlin server is a custom implementation to allow for more thorough testing, pls take a closer look at it.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@skarpovdev skarpovdev force-pushed the skarpov/integration-tests branch 2 times, most recently from 0f03d15 to f65c136 Compare August 5, 2025 17:36
@skarpovdev skarpovdev marked this pull request as ready for review August 5, 2025 18:14
@skarpovdev skarpovdev force-pushed the skarpov/integration-tests branch from f65c136 to acc50d3 Compare August 5, 2025 18:20
@devcrocod devcrocod self-requested a review August 6, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant