Fix JSON array response handling in StreamableHTTP client transport #1057
+15
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix JSON array response handling in StreamableHTTP client transport
Motivation and Context
The StreamableHTTP client transport's
_handle_json_response
method was not properly handling JSON array responses from servers. When a server returns multiple JSONRPCMessage objects as an array (e.g., batch responses), the current implementation would fail to parse them correctly. This issue was discovered when testing with servers that return array responses for certain operations liketools/list
.How Has This Been Tested?
Breaking Changes
None. This is a backward-compatible fix that maintains existing functionality while adding support for array responses.
Types of changes
Checklist
Additional context
The fix refactors the JSON parsing logic to:
This change ensures compatibility with MCP servers that may return batch responses or multiple messages in a single HTTP response, which is a valid pattern in JSON-RPC 2.0 specifications.