Skip to content

fix: improve misleading warning for progress callback exceptions #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+19 −11
Open

fix: improve misleading warning for progress callback exceptions #775

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6760af
fix: improve misleading warning for progress callback exceptions
lorenzocesconetto May 21, 2025
be40a3e
fix: small typo
lorenzocesconetto May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 19 additions & 11 deletions src/mcp/shared/session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,6 +379,14 @@ async def _receive_loop(self) -> None:
by_alias=True, mode="json", exclude_none=True
)
)
except Exception as e:
# For other validation errors, log and continue
logging.warning(
"Failed to validate notification: %s. Message was: %s",
e,
message.message.root,
)
else: # Notification is valid
# Handle cancellation notifications
if isinstance(notification.root, CancelledNotification):
cancelled_id = notification.root.params.requestId
Expand All @@ -392,19 +400,19 @@ async def _receive_loop(self) -> None:
# call it with the progress information
if progress_token in self._progress_callbacks:
callback = self._progress_callbacks[progress_token]
await callback(
notification.root.params.progress,
notification.root.params.total,
notification.root.params.message,
)
try:
await callback(
notification.root.params.progress,
notification.root.params.total,
notification.root.params.message,
)
except Exception as e:
logging.warning(
"Progress callback raised an exception: %s",
e,
)
await self._received_notification(notification)
await self._handle_incoming(notification)
except Exception as e:
# For other validation errors, log and continue
logging.warning(
f"Failed to validate notification: {e}. "
f"Message was: {message.message.root}"
)
else: # Response or error
stream = self._response_streams.pop(message.message.root.id, None)
if stream:
Expand Down
Loading