Webhooks #777
Draft
Webhooks #777
+240
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ), | ||
| HTTPStatus.OK, | ||
| ) | ||
| asyncio.create_task( |
There was a problem hiding this comment.
issue: we should start the this task before responding with a 200
| for webhook in webhooks: | ||
| headers = {"Content-Type": CONTENT_TYPE_JSON} | ||
| # Add authorization headers | ||
| if webhook.authentication and webhook.authentication.credentials: |
There was a problem hiding this comment.
question: how much of the auth logic is duplicate from what is there for Streamable HTTP? Can auth stuff be abstracted into a helper layer if it is same?
| creds_dict = json.loads(webhook.authentication.credentials) | ||
| if "username" in creds_dict and "password" in creds_dict: | ||
| # Create basic auth header from username and password | ||
| import base64 |
There was a problem hiding this comment.
suggestion: generally it is not a good idea to do imports in the runtime code like this as things that would fail at server startup may not fail until a request comes in that hits this path. Better to import this up top directly imo despite the fact that it might lead to more deps. btw is base64 part of the standard python libs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This is draft PR for the changes discussed in specification discussion #523.
How Has This Been Tested?
Tested by setting up a webhook, client and server locally. The webhook received all messages when the server was setup with streamable http. It was tested for both json_response True and False. All units tests succeeded.
Breaking Changes
None
Types of changes
Checklist