Skip to content

Support Sorbet typed tools #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Support Sorbet typed tools #10

wants to merge 2 commits into from
+87 −3

Conversation

chrisbutcher
Copy link

@chrisbutcher chrisbutcher commented May 16, 2025 •
edited
Loading

Motivation and Context

Fixes #9

How Has This Been Tested?

Second commit updates tools defined in tool_test.rb unit tests use the expected kwarg syntax.

Breaking Changes

None.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

@chrisbutcher chrisbutcher mentioned this pull request May 16, 2025
Open
@chrisbutcher chrisbutcher force-pushed the fix-sorbet-runtime-compatibility branch from 89a8eb7 to 3986fb9 Compare May 16, 2025 14:29
st0012
st0012 reviewed May 16, 2025
View reviewed changes
@chrisbutcher chrisbutcher force-pushed the fix-sorbet-runtime-compatibility branch from 3986fb9 to 31dd08e Compare May 16, 2025 18:26
@chrisbutcher chrisbutcher requested a review from st0012 May 16, 2025 18:26
@chrisbutcher chrisbutcher force-pushed the fix-sorbet-runtime-compatibility branch 2 times, most recently from 337631f to 7e33e76 Compare May 20, 2025 19:02
topherbullock added a commit that referenced this pull request May 20, 2025
@topherbullock
remove Gemfile.lock
afa0d8b 
ci on #10 is failing due to darwin deps in the lockfile.
fix ci by removing the gemfile and adding `bundle install` to ci steps
@topherbullock topherbullock mentioned this pull request May 20, 2025
Merged
9 tasks
@chrisbutcher chrisbutcher force-pushed the fix-sorbet-runtime-compatibility branch from 7e33e76 to 884acfe Compare May 20, 2025 19:14
@chrisbutcher chrisbutcher force-pushed the fix-sorbet-runtime-compatibility branch from 884acfe to 6e78209 Compare May 21, 2025 13:03
@chrisbutcher
Copy link
Author

cc: @topherbullock CI is 🟢

@atesgoral atesgoral requested review from topherbullock and removed request for st0012 May 24, 2025 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st0012 st0012 st0012 left review comments

@atesgoral atesgoral atesgoral approved these changes

@topherbullock topherbullock Awaiting requested review from topherbullock

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sorbet runtime call validation breaks MCP tool invocation
3 participants
@chrisbutcher @atesgoral @st0012