Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose all declared GitHub tools #712

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Cubbee
Copy link

@Cubbee Cubbee commented Mar 2, 2025

Description

There are a lot of commands declared in Github server readme, that were not exposed.
It caused clients ignoring the tools.

Server Details

  • Server: github
  • Changes to: index.ts

Motivation and Context

This change allows client to call additional tools that were already implemented, but not exposed, like get_pull_request_comments

How Has This Been Tested?

I've tested the added tools via Cursor, it works as expected

Breaking Changes

No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Protocol Documentation
  • My changes follows MCP security best practices
  • I have updated the server's README accordingly
  • I have tested this with an LLM client
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have documented all environment variables and configuration options

Additional context

@JuanJo-RC
Copy link

This change is very useful because it exposes additional tools that were already implemented in the server but were not accessible to clients. Thank you Cubbee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants