Skip to content

elicitation example #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

elicitation example #520

wants to merge 3 commits into from

Conversation

ihrpr
Copy link
Contributor

@ihrpr ihrpr commented May 20, 2025

npx tsx src/examples/server/simpleStreamableHttp.ts
npx tsx src/examples/client/simpleStreamableHttp.ts
Please provide the following information (attempt 1/3):
Rating (Rate your experience (1-5)) [1-5] *required*: 4
Comments (Additional comments (optional)): test
Would you recommend this? (Would you recommend this to others?) *required*: nope

✅ Collected data:
{
  "rating": 4,
  "comments": "test",
  "recommend": false
}

Submit this information? (yes/no/cancel): yes
Tool result:
  Thank you! Collected feedback information: {
  "rating": 4,
  "comments": "test",
  "recommend": false
}

> quit
Terminating session before exit...
Session terminated successfully

@bhosmer-ant
Copy link
Contributor

@ihrpr fyi rebased and fixed up the ajv imports and calls (needed due to the version downgrade)

FYI in addition to the stale resumption token issue (#530), I think there may be an issue when a request times out mid-elicitation. This was hard to repro and I'm not sure if it's due to the example code or deeper in the server logic.

@ihrpr
Copy link
Contributor Author

ihrpr commented May 22, 2025

I think there may be an issue when a request times out mid-elicitation.

We can set timeouts for requests and cover with tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants