Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deselection partial classes. #3653

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HansOlsson
Copy link
Collaborator

The basic issue are:

  • It was a bit unclear
  • Without this rule one has to introduce an intermediate level to be sure (see below), which is just weird.
  • One has to check whether a class is partial, even if it is isn't used

Old work-around:

model MyAmazingClass
  extends AExtra(break b);
end MyAmazingClass;
model AExtra "Work-around"
  extends A(redeclare B b);
end AExtra;

New without work-around:

model MyAmazingClass
  extends A(break b);
end MyAmazingClass;

with:

model A
  replaceable PartialB b;
end A;
partial model PartialB end PartialB;
model B
  extends PartialB;
end B;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant