treat chris-durands review

modm-io · Jun 19, 2022 · ce9bf1f · ce9bf1f
1 parent ce8a2d6
commit ce9bf1f
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 13 deletions.
diff --git a/src/modm/math/proportional_unsigned.hpp b/src/modm/math/proportional_unsigned.hpp
@@ -99,60 +99,60 @@ class ProportionalUnsigned {
 	ProportionalUnsigned
 	operator+(U value)
 	{
-		return {T(value_ + value) % (ProportionalUnsigned::max + 1)};
+		return {T(value_ + value) & ProportionalUnsigned::max};
 	}
 
 	template<std::integral U>
 	ProportionalUnsigned
 	operator-(U value)
 	{
-		return {T(value_ - value) % (ProportionalUnsigned::max + 1)};
+		return {T(value_ - value) & ProportionalUnsigned::max};
 	}
 
 	template<std::integral U>
 	ProportionalUnsigned
 	operator*(U value)
 	{
-		return {T(value_ * value) % (ProportionalUnsigned::max + 1)};
+		return {T(value_ * value) & ProportionalUnsigned::max};
 	}
 
 	template<std::integral U>
 	ProportionalUnsigned
 	operator/(U value)
 	{
-		return {T(value_ / value) % (ProportionalUnsigned::max + 1)};
+		return {T(value_ / value) & ProportionalUnsigned::max};
 	}
 
 	/// operator +=, -=, *=, /=
 	template<std::integral U>
 	ProportionalUnsigned&
 	operator+=(U value)
 	{
-		value_ = T(value_ + value) % (ProportionalUnsigned::max + 1);
+		value_ = T(value_ + value) & ProportionalUnsigned::max;
 		return *this;
 	}
 
 	template<std::integral U>
 	ProportionalUnsigned&
 	operator-=(U value)
 	{
-		value_ = T(value_ - value) % (ProportionalUnsigned::max + 1);
+		value_ = T(value_ - value) & ProportionalUnsigned::max;
 		return *this;
 	}
 
 	template<std::integral U>
 	ProportionalUnsigned&
 	operator*(U value)
 	{
-		value_ = T(value_ * value) % (ProportionalUnsigned::max + 1);
+		value_ = T(value_ * value) & ProportionalUnsigned::max;
 		return *this;
 	}
 
 	template<std::integral U>
 	ProportionalUnsigned&
 	operator/(U value)
 	{
-		value_ = T(value_ / value) % (ProportionalUnsigned::max + 1);
+		value_ = T(value_ / value) & ProportionalUnsigned::max;
 		return this;
 	}
 

diff --git a/src/modm/math/utils/misc.hpp b/src/modm/math/utils/misc.hpp
@@ -68,13 +68,13 @@ pow(uint32_t base, uint8_t exponent)
  * @see			https://stackoverflow.com/questions/23815138/implementing-variadic-min-max-functions
  */
 template<typename T>
-constexpr T vmin(T a, T b)
+constexpr T vmin(const T& a, const T& b)
 {
     return a < b ? a : b;
 }
 
 template<typename T, typename... Ts>
-constexpr T vmin(T a, T b, Ts&&... cs)
+constexpr T vmin(const T& a, const T& b, const Ts&... cs)
 {
     return a < b ? vmin(a, cs...) : vmin(b, cs...);
 }
@@ -91,13 +91,13 @@ constexpr T vmin(T a, T b, Ts&&... cs)
  * @see			https://stackoverflow.com/questions/23815138/implementing-variadic-min-max-functions
  */
 template<typename T>
-constexpr T vmax(T& a, T& b)
+constexpr T vmax(const T& a, const T& b)
 {
     return a > b ? a : b;
 }
 
 template<typename T, typename... Ts>
-constexpr T vmax(T& a, T& b, Ts&... cs)
+constexpr T vmax(const T& a, const T& b, const Ts&... cs)
 {
     return a > b ? vmax(a, cs...) : vmax(b, cs...);
 }

diff --git a/test/config/hosted.xml b/test/config/hosted.xml
@@ -7,6 +7,6 @@
   <modules>
     <module>modm:platform:core</module>
     <module>modm:driver:terminal</module>
-    <module>modm-test:test:**</module>
+    <module>modm-test:test:ui</module>
   </modules>
 </library>