I2S driver #769

rleh · 2021-10-29T22:52:07Z

Based on the great work #621 from @ledneczki.

DMA for all STM32
DMA: double buffer support (with dma-stream-channel type)
I2S driver (by @ledneczki)
CS43L22 DAC driver (by @ledneczki)
Example for STM32F407-DISCOVERY with embedded CS43L22 DAC
MA12070P DAC driver

examples/stm32f4_discovery/audio_i2s/main.cpp

Co-authored-by: Raphael Lehmann <[email protected]>

and remove deprecated enablePll() function that are not using `enablePll` struct. Co-authored-by: Raphael Lehmann <[email protected]>

Co-authored-by: Raphael Lehmann <[email protected]>

salkinium

Very awesome!

src/modm/driver/dac/ma12070p.lb

salkinium · 2022-02-28T23:51:45Z

src/modm/driver/dac/ma12070p.hpp

+	operator""_q_db(unsigned long long int value)
+	{
+		return ma12070p::quarter_decibel(value);
+	}


Is this really worth the effort for /4 or *4? This may not be a terrible conversion at runtime with a single cycle shift, and probablt done at compile time anyways.

I implemented the quarter decibel data type mainly to make it convenient for the user to use decibels in the application code without having to look up the meaning of otherwise unitless parameters for setMasterVolume(), etc...

salkinium · 2022-02-28T23:52:42Z

src/modm/driver/dac/ma12070p.hpp

+			os << "DcProtection ";
+		os << ")";
+		return os;
+	}


I remember some issues with name resolution that required these to be in the modm namespace.

Works fine...

We had some pretty obscure bugs where calling the operator did not work from within the modm namespace when defined in the global scope.

src/modm/driver/dac/ma12070p_impl.hpp

src/modm/platform/clock/stm32/rcc.hpp.in

src/modm/platform/i2s/stm32/i2s_base.hpp.in

src/modm/platform/i2s/stm32/i2s_master.hpp.in

rleh · 2022-03-07T23:44:31Z

I tested the example for the F407 discovery board successfully on hardware! ✅
MA12070P example next...

examples/stm32f469_discovery/audio_ma12070p/project.xml

examples/stm32f4_discovery/audio_i2s/project.xml

chris-durand

Nice!

src/modm/platform/i2s/stm32/i2s_master.hpp.in

chris-durand · 2022-03-09T21:23:47Z

src/modm/platform/dma/stm32/module.lb

@@ -186,6 +186,7 @@ def build(env):
    properties["dmaType"] = dma["type"]
    properties["dmaSignals"] = signal_names
    properties["dmaController"] = controller
+    properties["doubleBuffer"] = (dma["type"] in ["stm32-stream-channel"]) ## TODO: which other types support double buffer mode?


stm32-mux-stream is the combination of the stm32-stream-channel IP with the DMAMUX peripheral. It also supports double-buffered mode.

Suggested change

properties["doubleBuffer"] = (dma["type"] in ["stm32-stream-channel"]) ## TODO: which other types support double buffer mode?

properties["doubleBuffer"] = (dma["type"] in ["stm32-stream-channel", "stm32-mux-stream"])

I'll give it a try.

The DMA double buffer is currently not used anywhere with I2S, because that would make I2S more complicated or limit it to the devices with stm32-stream-channel/stm32-mux-stream DMA IP.
Works fine with the transfer complete interrupt, but maybe in the future someone can implement a mode with DMA double buffer and without interrupts.

src/modm/platform/i2s/stm32/i2s_base.hpp.in

src/modm/platform/dma/stm32/dma_hal.hpp.in

src/modm/driver/dac/ma12070p.hpp

src/modm/driver/dac/cs43l22.hpp

chris-durand · 2022-03-09T22:11:40Z

src/modm/architecture/interface/i2s_master.hpp

+/**
+ * Interface for a I2S Master
+ *
+ * @author	Marton Ledneczki
+ * @ingroup	modm_architecture_i2s
+ */
+class I2sMaster : public ::modm::PeripheralDriver


Should we somehow include in the name that this is an output device only? This interface does not describe a generic I²S master which could also receive audio or operate in time-multiplexed half-duplex mode. The terms master / slave do not imply a certain audio transfer direction, they only describe which device generates the clock.
If someone wanted to also implement input in the future there would be a naming issue.

In order to not break compatibility when (later) implementing I2S full-duplex/input functionality I would like to keep the class name, but add ONLY OUTPUT FUNCTIONALITY CURRENTLY IMPLEMENTED to the description.
(Slave (=clock receiver) would probably need another interface, but master with input you would probably just add more function/parameters to the current interface.)
What do you think?

chris-durand · 2022-03-09T22:23:11Z

src/modm/driver/dac/ma12070p.hpp

+			os << "DcProtection ";
+		os << ")";
+		return os;
+	}


We had some pretty obscure bugs where calling the operator did not work from within the modm namespace when defined in the global scope.

…late argument (struct)

19joho66 · 2023-03-13T17:21:30Z

Just curious, is this feature now completely off the table or is it somehow still in the loop?

rleh · 2023-03-13T22:13:03Z

I have planned to get my open pull requests (also those marked as "stale") merged before the next release (2023q1 scheduled for 01.04.2023). Let's see if I can do that.

The I2S driver here already works, as well as the I2C driver for the DAC CS43L22.
But the driver for the MA12070P chip (DAC with integrated Class-D amplifier) still has problems, so far no sound came out. But the dev board is (meanwhile again) on my desk.

In addition, the dual-buffering of the I2S driver is not yet solved optimally, a better solution should be found. But maybe not in this PR.

19joho66 · 2023-03-14T16:36:58Z

Thanks for the info and your efforts

rleh commented Oct 29, 2021

View reviewed changes

examples/stm32f4_discovery/audio_i2s/main.cpp Outdated Show resolved Hide resolved

salkinium added example 🔑 feature 🚧 advanced 🤯 labels Oct 30, 2021

rleh force-pushed the feature/i2s-stm32f407 branch from d62117f to cb61d8e Compare October 30, 2021 12:56

rleh changed the title ~~I2S driver (and DMA improvements)~~ I2S driver Nov 5, 2021

rleh force-pushed the feature/i2s-stm32f407 branch from 2cdb666 to 17cd5e3 Compare February 28, 2022 17:02

ledneczki and others added 10 commits February 28, 2022 23:32

[architecture] I2sMaster created

8f66fcc

Co-authored-by: Raphael Lehmann <[email protected]>

[dma] Support double buffer (only stm32-stream-channel)

e158b11

[rcc] Add support for I2S pll on STM32F4

294b380

and remove deprecated enablePll() function that are not using `enablePll` struct. Co-authored-by: Raphael Lehmann <[email protected]>

[board] Disco-F469: MicroSD card connector

e8b8e36

[stm32] I2S master implementation with DMA

5a040e0

Co-authored-by: Raphael Lehmann <[email protected]>

[driver] Add CS43L22 audio DAC (I2S + I²C)

d51569b

[board] Adapt STM32F4-Disco BSP for I2S DAC CS43L22

3bb021d

[example] STM32F4-Disco: CS43L22 I2S DAC example

ef6baee

[driver] Add MA12070P audio DAC (I2S + I²C)

9d7cae5

WIP [example] STM32F469-Disco: MA12070P I2S DAC example

d31ea26

rleh force-pushed the feature/i2s-stm32f407 branch from 17cd5e3 to d31ea26 Compare February 28, 2022 23:16

rleh marked this pull request as ready for review February 28, 2022 23:17

rleh requested review from salkinium and chris-durand February 28, 2022 23:17

salkinium requested changes Mar 1, 2022

View reviewed changes

rleh added 8 commits March 8, 2022 00:36

fixup_example_cs43l22

1a8494b

fixup_platform_i2s

9f243a2

fixup_architecture_i2s

5251e28

fixup_rcc

cb87fe0

fixup_ma12070p

db6e309

fixup_cs43l22

7b42b83

fixup_disco_f407vg

cc6cb20

fixup_example_ma12070p

9d38a46

rleh requested a review from salkinium March 7, 2022 23:43

rleh added 2 commits March 8, 2022 01:05

fixup platform i2s: disable stm32h7

eacad10

fixup platform i2s: stm32f410 has no PllI2s

001c09a

salkinium approved these changes Mar 8, 2022

View reviewed changes

examples/stm32f469_discovery/audio_ma12070p/project.xml Outdated Show resolved Hide resolved

examples/stm32f4_discovery/audio_i2s/project.xml Show resolved Hide resolved

chris-durand reviewed Mar 9, 2022

View reviewed changes

rleh added this to the 2022q1 milestone Mar 16, 2022

rleh added 8 commits March 18, 2022 12:46

fixup driver ma12070p

9b7d3e8

fixup example stm32f469_discovery/audio_ma12070p

a4cffe6

fixup audio_ma12070p: move to nucleo-f429 dev board

7406d7d

fixup example ma12070p: adapt changed I2sMaster API

a816af3

fixup platform/i2s: fix prescaler calculation, i2s config is now temp…

3ead27e

…late argument (struct)

fixup dma: enable double buffer also for 'stm32-mux-stream' IP

2c85e4f

fixup driver ma12070p

4859b64

fixup driver cs43l22

812d354

rleh mentioned this pull request Mar 28, 2022

2022q1 release #842

Merged

30 tasks

rleh modified the milestones: 2022q1, 2022q2 Mar 30, 2022

rleh modified the milestones: 2022q2, 2022q3 Jul 1, 2022

salkinium removed this from the 2022q3 milestone Oct 1, 2022

rleh added the stale ♾ label Mar 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

I2S driver #769

I2S driver #769

rleh commented Oct 29, 2021 •

edited

Loading

salkinium left a comment

salkinium Feb 28, 2022

rleh Mar 7, 2022

salkinium Feb 28, 2022

rleh Mar 7, 2022

chris-durand Mar 9, 2022

rleh commented Mar 7, 2022

chris-durand left a comment

chris-durand Mar 9, 2022

rleh Mar 10, 2022

chris-durand Mar 9, 2022

rleh Mar 11, 2022

chris-durand Mar 9, 2022

19joho66 commented Mar 13, 2023

rleh commented Mar 13, 2023

19joho66 commented Mar 14, 2023

	properties["doubleBuffer"] = (dma["type"] in ["stm32-stream-channel"]) ## TODO: which other types support double buffer mode?
	properties["doubleBuffer"] = (dma["type"] in ["stm32-stream-channel", "stm32-mux-stream"])

I2S driver #769

Are you sure you want to change the base?

I2S driver #769

Conversation

rleh commented Oct 29, 2021 • edited Loading

salkinium left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rleh commented Mar 7, 2022

chris-durand left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

19joho66 commented Mar 13, 2023

rleh commented Mar 13, 2023

19joho66 commented Mar 14, 2023

rleh commented Oct 29, 2021 •

edited

Loading