[architecture] Require setting SPI config in SpiDevice
based drivers
#820
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to move the discussion about a new API for setting the SPI configuration in
SpiDevice
based device drivers to a different place.As a first step a new
SpiConfiguration
struct is added underarchitecture
. Furthermore,modm::SpiDevice
will take that config struct as a non-type template parameter and provides a defaultconfigureBus()
function that applies the settings to the SPI master.EDIT: this does not work as expected, the platform-specific
SpiMaster
driver won't acceptmodm::Spi::DataMode
as an argument toSpiMaster::setDataMode()
.modm::platform::SpiMaster::DataMode
has to be used.