Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include XPCCs generated paths for VSCode C++ includePath #962

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

se-bi
Copy link
Contributor

@se-bi se-bi commented Feb 24, 2023

This extends the "includePath" list in .vscode/c_cpp_properties.json
when using the ::communication:xpcc:generator in combination with this ::ide:vscode
by e.g. this entry: "${workspaceFolder}/generated/xpcc/".

Points open for discussion:

  • How to get rid of that message, because it does not matter(?):
    [WARNING] lbuild.node: Module 'modm:ide:vscode' accessing 'modm:communication:xpcc:generator:path' without depending on 'modm:communication:xpcc:generator'!
  • The os.makedirs is kind of a workaround to create that empty directory structure here.
    But if the workspace is opened in VS Code with that directory missing, it does not get over it.
    With the directory existing but files not (later created with scons) it gets along with that later.
  • This itself is also kind of a workaround since this is generated with scons and there added to the includePath for the actual build
  • Reduced number of XPCC example does not make it easy to test.
    • and btw. with the avr example it seems to reveal that there are some includes not properly..?
      The platform/gpio/port.hpp has an include for math/utils/bit_operation.hpp which is not generated/copied by LBuild

@salkinium salkinium added this to the 2023q1 milestone Feb 25, 2023
@salkinium
Copy link
Member

I'll look into it next weekend. I saw that the VSCode Debug plugins got more features, so I'll probably need to adapt this anyways again.

@salkinium salkinium self-assigned this Feb 26, 2023
@rleh rleh modified the milestones: 2023q1, 2023q2 Apr 8, 2023
@rleh rleh added the stale ♾ label May 8, 2023
@rleh rleh removed this from the 2023q2 milestone May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants