check if settings is set to a value to prevent cache corruption #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if I'm seeing how this helps - $settings is being set on line 82 so this is always going to run? Wasn't #211 also about the lexicon cache, not the ClientConfig cache itself? Feels like I'm missing something 😅 |
|
I tested it with 2 Projects and after i removed this Check, it got corrupted in like a day. This was the point where the cache was set. |
Mark-H
approved these changes
Jan 24, 2025
|
Thanks @Peeet93 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do ?
check if settings is set to a value to prevent cache corruption
Why is it needed ?
#211
Related issue(s)/PR(s)
#211