Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed non english file names generation #442

Merged
merged 1 commit into from
Dec 9, 2023

Conversation

livingroot
Copy link
Contributor

What does it do ?

replaced SplFileInfo::getBasename() calls with SplFileInfo::getFilename()

Why is it needed ?

  1. If yaml file name starts with non-english characters, gitify build removed those files.

Example:

$file = new SplFileInfo("directory/файл.txt"); // file, which contains cyrillic characters
var_dump($file->getBasename());
var_dump($file->getFilename());

output:

string(4) ".txt" // wrong
string(12) "файл.txt" // correct

Related issue: #188

@Mark-H
Copy link
Member

Mark-H commented Sep 26, 2023

Thanks for the PR, we'll test this and include it on the next release. 💙

@muzzwood muzzwood merged commit 09062b7 into modmore:master Dec 9, 2023
@muzzwood
Copy link
Contributor

muzzwood commented Dec 9, 2023

This appears to work without issue. Thanks for your contribution @livingroot ! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants