Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: manage implementation option + fix circular import issue #191

Merged
merged 5 commits into from
Nov 25, 2024
Merged

fix: manage implementation option + fix circular import issue #191

merged 5 commits into from
Nov 25, 2024

Conversation

zhangHongEn
Copy link
Contributor

@zhangHongEn zhangHongEn commented Nov 25, 2024 •
edited
Loading

fix:
#180
#179

feat:
implementation

@zhangHongEn zhangHongEn mentioned this pull request Nov 25, 2024
Closed
@gioboa
Copy link
Collaborator

gioboa commented Nov 25, 2024

Fixes: #157

gioboa
gioboa approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zhangHongEn
you are really great 👏

@gioboa gioboa changed the title fix: #180 Circular Import fix: #180 #179 #157 issues Nov 25, 2024
@gioboa gioboa changed the title fix: #180 #179 #157 issues fix: manage implementation option + fix circular import issue Nov 25, 2024
@gioboa gioboa merged commit a8a0102 into module-federation:main Nov 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gioboa gioboa gioboa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhangHongEn @gioboa