Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move vitest as devDependency #195

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

yuvalkarif
Copy link
Contributor

@yuvalkarif yuvalkarif commented Nov 26, 2024

Great work on the package, found it while going over the code :)

https://vitest.dev/guide/#adding-vitest-to-your-project

Copy link
Collaborator

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yuvalkarif
Kudos for your first contribution into this project 🥳

@gioboa gioboa changed the title fix: vitest should be a devDependency chore: move vitest as devDependency Nov 26, 2024
@gioboa gioboa merged commit 30ab658 into module-federation:main Nov 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants