New password generation method: send user email # 15461 #16519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 3.x #16519 +/- ##
============================================
- Coverage 21.68% 21.63% -0.05%
- Complexity 10496 10502 +6
============================================
Files 561 561
Lines 31703 31771 +68
============================================
Hits 6875 6875
- Misses 24828 24896 +68 ☔ View full report in Codecov by Sentry. |
|
@Mark-H — if you have a moment, could you take a look at resolving the conflicts in this so I can get it integrated? |
Tweaks from feedback and phpstorm hints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
This is a re-up of #15461 originally by @sdrenth back in 2021, which has gone stale waiting for some minor changes. I've rebased it, tweaked it, tested it, so we can include it in 3.1.
This adds a new option for setting the password when creating/updating a user: send the user a link to set their password. That's more secure and builds upon improvements to the password reset flow that was done in 3.0.
Why is it needed?
Showing the password on screen or manually setting a password is kinda outdated and insecure.
How to test
Create and/or edit a user, and choose "Let the user choose their own password via email" for the password method. Look for the email (make sure you have email delivery set up beforehand) and attempt to set the new password.
Related issue(s)/PR(s)
This PR replaces the stale PR #15461
Sterc#22
#13973
Sterc#31