-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add InputObservations #129
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ce8f08c
to
bb4a2bc
Compare
3ec04ee
to
0f7e98e
Compare
moeyensj
commented
Nov 17, 2023
a56d1ae
to
7ab1230
Compare
42ac305
to
c8bae2c
Compare
…s in Observations
…string when creating a test orbit directory path
c8bae2c
to
a978bec
Compare
Tests and linting pass locally so I'll merge this. Looks like there is an upstream issue getting the OBSCODE file from the MPC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new table
InputObservations
that represents de-normalized combinations of detections and their exposure information (such as those available in AIMS and commonly available in other places):The Observations table has a new constructor
Observations.from_input_observations(input_observations)
that maps the input observations into the format used by THOR, namely bylink_test_orbit
. The THOR observation table has been modified to use SphericalCoordinates instead of PointSourceDetections.The transition to spherical coordinates is convenient since operations are more often than not done on coordinate classes and not PointSourceDetections.
This PR also adds a Photometry table used by THOR observations which I anticipate will one day be added to adam_core for use in things like light curve fitting.