Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InputObservations #129

Merged
merged 10 commits into from
Nov 20, 2023
Merged

Add InputObservations #129

merged 10 commits into from
Nov 20, 2023

Conversation

moeyensj
Copy link
Owner

@moeyensj moeyensj commented Nov 14, 2023

This PR introduces a new table InputObservations that represents de-normalized combinations of detections and their exposure information (such as those available in AIMS and commonly available in other places):

import quivr as qv
from adam_core.time import Timestamp

class InputObservations(qv.Table):
    id = qv.StringColumn()
    exposure_id = qv.StringColumn()
    time = Timestamp.as_column()
    ra = qv.Float64Column()
    dec = qv.Float64Column()
    ra_sigma = qv.Float64Column(nullable=True)
    dec_sigma = qv.Float64Column(nullable=True)
    ra_dec_cov = qv.Float64Column(nullable=True)
    mag = qv.Float64Column()
    mag_sigma = qv.Float64Column(nullable=True)
    filter = qv.StringColumn()
    observatory_code = qv.StringColumn()

The Observations table has a new constructor Observations.from_input_observations(input_observations) that maps the input observations into the format used by THOR, namely by link_test_orbit. The THOR observation table has been modified to use SphericalCoordinates instead of PointSourceDetections.

The transition to spherical coordinates is convenient since operations are more often than not done on coordinate classes and not PointSourceDetections.

This PR also adds a Photometry table used by THOR observations which I anticipate will one day be added to adam_core for use in things like light curve fitting.

@moeyensj moeyensj force-pushed the v2.0-observations-with-states branch from ce8f08c to bb4a2bc Compare November 14, 2023 21:36
@moeyensj moeyensj changed the title Add ObservationsWithStates Add InputObservations Nov 15, 2023
@moeyensj moeyensj force-pushed the v2.0-observations-with-states branch 2 times, most recently from 3ec04ee to 0f7e98e Compare November 17, 2023 04:55
@moeyensj moeyensj marked this pull request as ready for review November 17, 2023 04:56
@moeyensj moeyensj force-pushed the v2.0-observations-with-states branch 3 times, most recently from a56d1ae to 7ab1230 Compare November 20, 2023 17:31
@moeyensj moeyensj force-pushed the v2.0-observations-with-states branch 2 times, most recently from 42ac305 to c8bae2c Compare November 20, 2023 19:43
@moeyensj moeyensj force-pushed the v2.0-observations-with-states branch from c8bae2c to a978bec Compare November 20, 2023 20:04
@moeyensj
Copy link
Owner Author

Tests and linting pass locally so I'll merge this. Looks like there is an upstream issue getting the OBSCODE file from the MPC.

@moeyensj moeyensj merged commit 249a81c into main Nov 20, 2023
@moeyensj moeyensj deleted the v2.0-observations-with-states branch November 20, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants