-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swap to pdm #166
Swap to pdm #166
Conversation
815dc6f
to
2de91cd
Compare
9958350
to
50fcd5f
Compare
The last item to complete is to set the adam_core and adam_pyoorb git hashes once changes in those packages have been merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a fantastic change. I'd like to very soon get a solid release of adam-core out so we can point to >= a specific pypi version.
with: | ||
install: true | ||
- name: Build | ||
run: docker build --load -t thor:$IMAGE_TAG . | ||
- name: Lint | ||
run: docker run -i thor:$IMAGE_TAG pre-commit run --all-files | ||
run: docker run -i thor:$IMAGE_TAG pdm lint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can dump the docker builds altogether with the simpler pyoorb / numpy install?
Swap to using the pdm build system.