Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[conf] Update Github action runner os #498

Merged
merged 2 commits into from
Feb 27, 2025
Merged

[conf] Update Github action runner os #498

merged 2 commits into from
Feb 27, 2025

Conversation

cpjolicoeur
Copy link
Member

@cpjolicoeur cpjolicoeur commented Feb 27, 2025

ubuntu-20.04 is deprecated

https://github.com/actions/runner-images

Summary by CodeRabbit

  • Chores
    • Upgraded continuous integration environments to newer operating system versions, ensuring improved dependency support and enhanced testing reliability.
    • Standardized configuration settings for consistency across the testing pipeline.
    • Updated README to reflect new requirements for OTP version and modified Elixir installation link.

@mojotech mojotech deleted a comment from coderabbitai bot Feb 27, 2025
Copy link

coderabbitai bot commented Feb 27, 2025

Walkthrough

This pull request updates two CI workflow configuration files and the README.md. In .github/workflows/ci.yml, the mix_test job is modified to run on ubuntu-24.04, with the ImageOS environment variable changed from ubuntu20 to ubuntu24, and the string formatting for node-version and cache has been standardized to use double quotes. In .github/workflows/v4.yml, the mix_test job is updated to run on ubuntu-22.04, a new ImageOS environment variable is added (set to ubuntu22), and similar formatting adjustments are applied. The README.md file is updated to include a new requirement for OTP version 24 or higher and an updated link for Elixir installation.

Changes

Files Change Summary
.github/workflows/ci.yml, .github/workflows/v4.yml Updated mix_test job OS version (to ubuntu-24.04 in ci.yml and ubuntu-22.04 in v4.yml), updated/added ImageOS environment variable (ubuntu24 in ci.yml and ubuntu22 in v4.yml), and standardized string formatting for node-version and cache (changed from single to double quotes).
README.md Added requirement for OTP version 24 or higher and updated Elixir installation link from general to specific.

Poem

I’m a rabbit hopping through codes so neat,
Delighting in upgrades that make CI complete.
OS shifts and env variables in a row,
Like carrots lined up for a joyful glow.
With double-quote charm and a skip in my beat,
I celebrate these changes with a happy, darting leap!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 32b82e7 and 3c437c3.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml (2 hunks)
  • README.md (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/ci.yml
🔇 Additional comments (2)
README.md (2)

24-24: Updated Elixir Installation Requirement Link

The change now directs users to the more specific installation page for Elixir (https://elixir-lang.org/install.html) rather than the general homepage. This makes it easier for developers to access the relevant instructions for setting up Elixir.


25-25: Added OTP 24+ Requirement

The addition of the OTP 24+ prerequisite, along with the corresponding download link (https://www.erlang.org/downloads), clearly communicates the new dependency. This ensures users are aware of the updated runtime requirements aligned with your CI configuration updates.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/workflows/ci.yml (1)

60-60: Mismatched OS Comment
Although the environment variable ImageOS is now set to ubuntu24, the trailing comment still references ubuntu-20.04, which is inconsistent with the updated runs-on value. It is recommended to update the comment to accurately depict the new configuration.

Suggested diff:

-      ImageOS: ubuntu24 # run on ubuntu-20.04 (which supports Erlang/OTP 24.3-27)
+      ImageOS: ubuntu24 # run on ubuntu-24.04 (which supports Erlang/OTP 24.3-27)
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d037a7a and 32b82e7.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml (2 hunks)
  • .github/workflows/v4.yml (2 hunks)
🔇 Additional comments (5)
.github/workflows/v4.yml (3)

15-15: OS Upgrade Confirmed
The runs-on field has been updated to ubuntu-22.04 as expected. This update aligns with the PR objectives and ensures compatibility with the newer GitHub Actions runner image.


60-60: Environment Variable ImageOS Set Correctly
The new ImageOS: ubuntu22 environment variable is introduced with an accompanying comment that describes its purpose (supporting Erlang/OTP versions 24.2-27 on ubuntu-22.04). Please ensure that this variable is used consistently across all jobs if referenced elsewhere.


66-67: Standardized String Formatting for Node Setup
Changing the node-version and cache values to use double quotes improves consistency in our workflow files. This update is a straightforward style improvement consistent with the rest of the repository changes.

.github/workflows/ci.yml (2)

15-15: OS Upgrade in CI Workflow
The runs-on attribute has been changed to ubuntu-24.04, which meets the updated CI requirements. This change ensures that the CI pipeline runs on a supported and up-to-date OS.


66-67: Consistent Node Setup Configuration
The changes to node-version ("18") and cache ("npm") in the actions/setup-node step are consistent with the changes made in the other workflow file. This standardization helps maintain uniformity in the CI setup.

@cpjolicoeur cpjolicoeur merged commit 80c4ee8 into master Feb 27, 2025
18 checks passed
@cpjolicoeur cpjolicoeur deleted the cpj/gh-runners branch February 27, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant