-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[conf] Update Github action runner os #498
Conversation
ubuntu-20.04 is deprecated https://github.com/actions/runner-images
e2fe0f5
to
32b82e7
Compare
WalkthroughThis pull request updates two CI workflow configuration files and the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
🔇 Additional comments (2)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/ci.yml (1)
60-60
: Mismatched OS Comment
Although the environment variableImageOS
is now set toubuntu24
, the trailing comment still referencesubuntu-20.04
, which is inconsistent with the updatedruns-on
value. It is recommended to update the comment to accurately depict the new configuration.Suggested diff:
- ImageOS: ubuntu24 # run on ubuntu-20.04 (which supports Erlang/OTP 24.3-27) + ImageOS: ubuntu24 # run on ubuntu-24.04 (which supports Erlang/OTP 24.3-27)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/ci.yml
(2 hunks).github/workflows/v4.yml
(2 hunks)
🔇 Additional comments (5)
.github/workflows/v4.yml (3)
15-15
: OS Upgrade Confirmed
Theruns-on
field has been updated toubuntu-22.04
as expected. This update aligns with the PR objectives and ensures compatibility with the newer GitHub Actions runner image.
60-60
: Environment VariableImageOS
Set Correctly
The newImageOS: ubuntu22
environment variable is introduced with an accompanying comment that describes its purpose (supporting Erlang/OTP versions 24.2-27 on ubuntu-22.04). Please ensure that this variable is used consistently across all jobs if referenced elsewhere.
66-67
: Standardized String Formatting for Node Setup
Changing thenode-version
andcache
values to use double quotes improves consistency in our workflow files. This update is a straightforward style improvement consistent with the rest of the repository changes..github/workflows/ci.yml (2)
15-15
: OS Upgrade in CI Workflow
Theruns-on
attribute has been changed toubuntu-24.04
, which meets the updated CI requirements. This change ensures that the CI pipeline runs on a supported and up-to-date OS.
66-67
: Consistent Node Setup Configuration
The changes tonode-version
("18") andcache
("npm") in theactions/setup-node
step are consistent with the changes made in the other workflow file. This standardization helps maintain uniformity in the CI setup.
ubuntu-20.04 is deprecated
https://github.com/actions/runner-images
Summary by CodeRabbit