Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language selections example #12

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Language selections example #12

wants to merge 2 commits into from

Conversation

Simard302
Copy link
Collaborator

Overview

This PR creates a new example for creating selections based on PyMOL, VMD, and Jmol selection languages (and coloring the selection).

Changes made

  • Created selections example "select_from_language"
    • Make a selection from PyMOL
    • Make a selection from VMD
    • Make a selection from Jmol

How to test

Ensure the 3 selections are shown and colored (Red, Green, Blue) properly

Specific review requests

For each of the examples:

  • Are there enough comments to sufficiently describe the process?
  • Are the comments accurately describing the process?
  • Are there any anti-patterns in the examples?
  • Can the examples be more efficient?

@Simard302 Simard302 requested a review from papillot June 11, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant