Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new terms #8792

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

add new terms #8792

wants to merge 12 commits into from

Conversation

nicolevasilevsky
Copy link
Member

@nicolevasilevsky nicolevasilevsky commented Feb 26, 2025

@katiermullen

FYI, this is my robot template

close #8785
close #8753
close #8754
close #8757
close #8758
close #8759
close #8763
close #8778
close #8784

@nicolevasilevsky nicolevasilevsky marked this pull request as ready for review February 27, 2025 00:24
@nicolevasilevsky
Copy link
Member Author

@sabrinatoro and/or @cmungall - do either of you want to review this PR? ClinGen requested a lot of new grouping classes based on gene names. I checked where synonyms should be added to existing terms instead and did that in a couple cases. Otherwise, I thought their grouping classes made sense.

Copy link
Collaborator

@katiermullen katiermullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicolevasilevsky please see in-line comments

[Term]
id: MONDO:0100591
name: TOR1AIP1-related multisystem disorder
def: "TOR1AIP1-related multisystem disorder is a rare, early-onset disorder affecting multiple organ systems that is caused by variation in the TOR1AIP1 gene. Clinical features reported in affected individuals are variable but may include hypotonia, dystonia, cerebellar atrophy, contractures, cardiomyopathy, microcephaly, cataract, deafness, skeletal anomalies, progeroid appearance and other facial dysmorphism, and nephrolithiasis. TOR1AIP1-related multisystem disorder, like TOR1AIP1-related myopathy, is considered a subtype of the broader phenotypic spectrum of TOR1AIP1-related nuclear envelopathy caused by loss of function of the TOR1AIP1 gene." [https://clinicalgenome.org/affiliation/40060/, https://clinicalgenome.org/affiliation/40151/, PMID:25425325, PMID:30723199, PMID:32055997]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider putting some of the details in a comment.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


[Term]
id: MONDO:0100604
name: TOR1AIP1-related nuclear envelopathy
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm that the child of this term, 'TOR1AIP1-related myopathy' is distinct from the grandchild term 'autosomal recessive limb-girdle muscular dystrophy type 2Y'?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think myopathies and muscular dystrophies are distinct:
https://pubmed.ncbi.nlm.nih.gov/11562568/

@@ -107017,7 +107017,7 @@ synonym: "congenital anomaly of cartilage" NARROW []
synonym: "congenital skeletal dysplasia" EXACT [NCIT:C84978]
synonym: "osteochondrodysplasia" EXACT [DOID:2256, NCIT:C84978]
synonym: "osteochondrodysplasia syndrome" EXACT [DOID:2256]
synonym: "skeletal dysplasia" RELATED []
synonym: "skeletal dysplasia" BROAD []
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a reference for this syn?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@@ -164388,7 +164389,7 @@ property_value: seeAlso "https://rarediseases.info.nih.gov/diseases/3571/metatro
[Term]
id: MONDO:0007987
name: Kniest dysplasia
def: "Kniest dysplasia is a severe type II collagenopathy characterized by a short trunk and limbs, prominent joints and midface hypoplasia (round face with a flat nasal root)." [Orphanet:485]
def: "A rare type 2 collagen-related bone disorder characterized by moderately severe chondrodysplasia with disproportionate short stature of prenatal onset, prominent joints with restricted mobility, large epiphyses and dumbbell deformity of the long bones. It was first described in 1952 by Dr Wilhelm Kniest, a German pediatrician." [Orphanet:485]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the last sentence of the definition could be placed in a comment or excluded?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed it

@@ -164412,14 +164413,14 @@ xref: Orphanet:485 {source="OMIM:156550", source="MONDO:equivalentTo"}
xref: SCTID:53974002 {source="MONDO:equivalentTo"}
xref: UMLS:C0265279 {source="MEDGEN:75559", source="MONDO:equivalentTo", source="MONDO:MEDGEN"}
is_a: MONDO:0005516 {source="DOID:0080045", source="MESH:C537207"} ! osteochondrodysplasia
is_a: MONDO:0016761 {source="Orphanet:485"} ! spondyloepiphyseal dysplasia
is_a: MONDO:0016763 {source="OMIM:156550"} ! spondylometaphyseal dysplasia
is_a: MONDO:0022800 {source="Orphanet:485", source="PMID:31633310"} ! type 2 collagenopathy
relationship: curated_content_resource https://search.clinicalgenome.org/kb/conditions/MONDO:0007987 {source="MONDO:CLINGEN"}
relationship: disease_has_feature HP:0000272 ! Malar flattening
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no sources for these relationships. Is it possible to add them?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

[Term]
id: MONDO:0100592
name: SLC26A2-related skeletal dysplasia
def: "Any skeletal disorder in which the cause of the disease is a variant in the SLC26A2 gene. This includes SLC26A2-related Achondrogenesis, SLC26A2-related atelosteogenesis, SLC26A2-related diastrophic dysplasia, and SLC26A2-related multiple epiphyseal dysplasia." [https://clinicalgenome.org/affiliation/40065/]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SLC26A2-related achondrogenesis (lower case)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

revise def
fix typo
@nicolevasilevsky
Copy link
Member Author

@katiermullen I addressed all of your comments
@sabrinatoro could you please take a look and make sure this aligns with the workflows you've been discussing with ClinGen for their new term requests?

@nicolevasilevsky
Copy link
Member Author

open action items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment