Skip to content

COMPASS-9700 #7198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 26 commits into
base: main
Choose a base branch
from
Draft

COMPASS-9700 #7198

wants to merge 26 commits into from

Conversation

DarshanaVenkatesh
Copy link
Collaborator

Description

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added
  • If this change updates the UI, screenshots/videos are added and a design review is requested
  • I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

DarshanaVenkatesh and others added 24 commits August 7, 2025 13:23
@DarshanaVenkatesh
add banners to indexes tab
0b4ab54
@DarshanaVenkatesh
update banner to include data explorer versions
0c96520
@DarshanaVenkatesh
fetching search indexes for view
6bc7021
@DarshanaVenkatesh
fix indexes-toolbar
8cc8504
@DarshanaVenkatesh
update ui
aaf0f70
@DarshanaVenkatesh
Merge branch 'main' into COMPASS-9667
cdbbfc8
@DarshanaVenkatesh
update indexes-toolbar test
481bbd4
@DarshanaVenkatesh
add tests to indexes.spec.tsx
b9be029
@DarshanaVenkatesh
only fetch indexes for version 8.1+
6d9d8b8
@DarshanaVenkatesh
fix conditionals
8f2ec15
@DarshanaVenkatesh
Merge branch 'main' into COMPASS-9667
5b976d3
@DarshanaVenkatesh
change or to and
fbbb21f
@DarshanaVenkatesh
add to useEffect conditional
50cee9a
@DarshanaVenkatesh
remove fetch for version
aa59476
@DarshanaVenkatesh
add verison check back but remove from store
26e428b
@DarshanaVenkatesh
pr review changes
73b536b
@DarshanaVenkatesh
move function
6961789
@DarshanaVenkatesh
Merge branch 'main' into COMPASS-9667
f6cee34
@DarshanaVenkatesh
fix indexes-toolbar.spec
cd9de5b
@DarshanaVenkatesh
fix initial state import
6c47264
@DarshanaVenkatesh
attempting to add model
4b9ac1e
@DarshanaVenkatesh
update close
3544c3b
@DarshanaVenkatesh
error isn't showing
8966b4e
@DarshanaVenkatesh
update view does not open model
dae1f5f
gribnoysup
gribnoysup reviewed Aug 14, 2025
View reviewed changes
Copy link
Collaborator

@gribnoysup gribnoysup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use showConfirmation method from @mongodb-js/compass-components instead of this custom built confirmation modal logic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gribnoysup gribnoysup gribnoysup left review comments

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DarshanaVenkatesh @gribnoysup