-
Notifications
You must be signed in to change notification settings - Fork 8
NODE-6950: add langchainjs to testing pipeline #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
fd30f52
to
909777a
Compare
0ac86b3
to
8aef9b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I pulled from main to pick up #69
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few questions
expansions: | ||
DIR: langchain-js | ||
run_on: | ||
- ubuntu2204-small |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how did we choose the distro? the readme in this repo says:
rhel87-small should be used by default. Any other distro may fail Atlas CLI setup.
presumably, ubuntu2204 doesn't fail any setup, but I am still wondering what drove the specific choice
@@ -0,0 +1,18 @@ | |||
{ | |||
"name": "default", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this index relate to a specific test or tests in the langchain-js suite?
|
||
set -o errexit | ||
|
||
setup_remote_atlas() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the relationship between this script and the general setup-remote.sh that executes beforehand?
source $ROOT_DIR/env.sh | ||
fi | ||
|
||
bash ../../.evergreen/fetch-secrets.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just curious why we try to define the absolute path above but then use a relative path here
|
||
setup_node_and_yarn() { | ||
# setup node, npm and yarn | ||
PATH=/opt/devtools/node22/bin:$(pwd)/bin:$PATH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any thoughts on how to best keep track of all the places where we use a fixed node version so that we can remember to update it when it becomes deprecated?
We changed the structure of
|
This PR adds testing of langchainjs' mongodb integration in the testing pipeline. This PR currently uses a branch from my fork of langchainjs. If this PR is ready to merge before langchain-ai/langchainjs#8154, I'll file a ticket to remove the reference to my langchainjs fork after langchain-ai/langchainjs#8154 merges and we can merge this PR.