REP-5806 Parse document filter as extended JSON #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FGasper
force-pushed
the
REP-5806-doc-filter-ext-json
branch
from
803c1ba to
ce20362
Compare
ajayvijayakumar123
requested changes
May 2, 2025
Previously we parsed the document filter as plain JSON, which made it impossible to filter on ObjectID or other BSON-specific types. This changeset fixes that by parsing the document filter as MongoDB’s extended JSON.
This avoids hard-to-understand phrases like this: > failed comparison on field counter between srcClient ... … which really sounds like there is a counter for fields rather than a field named “counter”.
FGasper
force-pushed
the
REP-5806-doc-filter-ext-json
branch
from
cb297d9 to
597d268
Compare
tdq45gj
approved these changes
May 2, 2025
|
|
||
| func (ejb extJSONBindingType) Bind(req *http.Request, obj any) error { | ||
| if req == nil || req.Body == nil { | ||
| return errors.New("invalid request") |
There was a problem hiding this comment.
Should req.Body == nil be an error or should it return an empty struct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we parsed the document filter as plain JSON, which made it impossible to filter on ObjectID or other BSON-specific types.
This changeset fixes that by parsing the document filter as MongoDB’s extended JSON.
I’m going to merge the commits as-is rather than squashing. Note that there are two unrelated UX improvements here, as well as a fix for a race condition in an unrelated test, in discrete commits.