REP-6465 Switch doc key to fill in null values. #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FGasper
changed the title
FGasper
force-pushed
the
felipe_simpler_doc_key
branch
5 times, most recently
from
0b2f6a9 to
10c76c2
Compare
mmcclimon
approved these changes
Aug 22, 2025
internal/util/sharding.go
Outdated
Comment on lines
72
to
77
| bson.M{"_id": ns}, | ||
| bson.M{ | ||
| "$set": bson.M{ | ||
| "noBalance": true, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
(nit) It doesn't really matter since these are single-value maps, but shouldn't these be bson.Ds instead?
This amends PR mongodb-labs#127 so that, if a document lacks a shard key field, the generated document key will include that field with a null value. This matches the server’s internal logic and seems safer besides.
This fixes intermittent failures in PR mongodb-labs#127’s new dotted-key sharding test.
FGasper
force-pushed
the
felipe_simpler_doc_key
branch
from
10c76c2 to
351801a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #127 merged before review was finished. This changeset addresses an outstanding item that the last PR left unresolved: specifically, the computed document key will now always include a value for each field in the shard key, even if the field is not present in the document.
Another commit fixes a flap in that other PR’s test.
Both commits will be preserved in the merge.