Skip to content

DOCSP-49054: Connection targets #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: docsp-45382-comp-cvg
Choose a base branch
from

Conversation

mcmorisi
Copy link
Collaborator

@mcmorisi mcmorisi commented Apr 11, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-49054

Staging Links

  • connect/connection-options/server-selection
  • connect/connection-targets
  • connect/mongoclient
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?
    • Are the page titles greater than 20 characters long and SEO relevant?

    Copy link

    netlify bot commented Apr 11, 2025

    Deploy Preview for docs-csharp ready!

    Name Link
    🔨 Latest commit ad9b8c2
    🔍 Latest deploy log https://app.netlify.com/sites/docs-csharp/deploys/680f8bb66b08d80008152587
    😎 Deploy Preview https://deploy-preview-589--docs-csharp.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    Copy link
    Collaborator

    @stephmarie17 stephmarie17 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Nice work! A few small suggestions/questions.

    @mcmorisi mcmorisi requested a review from stephmarie17 April 14, 2025 13:05
    Copy link
    Collaborator

    @stephmarie17 stephmarie17 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM!

    @mcmorisi mcmorisi requested review from a team, JamesKovacs and papafe and removed request for a team and JamesKovacs April 14, 2025 15:42

    // Sets the connection URI than includes the replica set name
    const string connectionUri = "mongodb://host1:27017,host2:27017,host3:27017";
    Copy link

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I think you forgot to include the replica set name here?

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I believe the comment here is incorrect! Can fix it.

    Copy link

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    @sanych-sun Another question... If we don't specify the replica set name here, wouldn't it be considered a standalone cluster?

    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    If we do not specify the replicaset name, it should be automatically discovered. However it's recommended to include the replicaset into the connection string if possible, to avoid wrong initialization in some corner cases (for example if connection seed list contains several hosts which are connected to a different replicasets - then result of connecting might depends on the fact what server reply first.)

    @mcmorisi mcmorisi requested a review from papafe April 25, 2025 15:42
    @mcmorisi mcmorisi requested a review from sanych-sun April 28, 2025 14:07
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants