-
Notifications
You must be signed in to change notification settings - Fork 24
DOCSP-49054: Connection targets #589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: docsp-45382-comp-cvg
Are you sure you want to change the base?
DOCSP-49054: Connection targets #589
Conversation
✅ Deploy Preview for docs-csharp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! A few small suggestions/questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
||
// Sets the connection URI than includes the replica set name | ||
const string connectionUri = "mongodb://host1:27017,host2:27017,host3:27017"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you forgot to include the replica set name here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the comment here is incorrect! Can fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sanych-sun Another question... If we don't specify the replica set name here, wouldn't it be considered a standalone cluster?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we do not specify the replicaset name, it should be automatically discovered. However it's recommended to include the replicaset into the connection string if possible, to avoid wrong initialization in some corner cases (for example if connection seed list contains several hosts which are connected to a different replicasets - then result of connecting might depends on the fact what server reply first.)
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-49054
Staging Links
Self-Review Checklist