Skip to content

DOCSP-49078: Extended JSON #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: docsp-45382-comp-cvg
Choose a base branch
from

Conversation

mcmorisi
Copy link
Collaborator

@mcmorisi mcmorisi commented Apr 23, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-49078

Staging Links

  • data-formats/extended-json
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?
    • Are the page titles greater than 20 characters long and SEO relevant?

    Copy link

    netlify bot commented Apr 23, 2025

    Deploy Preview for docs-csharp ready!

    Name Link
    🔨 Latest commit 7d0c7d3
    🔍 Latest deploy log https://app.netlify.com/sites/docs-csharp/deploys/681126e5d02f9400087d7e0a
    😎 Deploy Preview https://deploy-preview-619--docs-csharp.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    Copy link
    Collaborator

    @rachel-mack rachel-mack left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    The "Overview" and "Extended JSON Formats" sections seem like good candidates for the docs-shared repo:

    @mcmorisi mcmorisi requested a review from rachel-mack April 24, 2025 16:14
    Copy link
    Collaborator

    @rachel-mack rachel-mack left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM

    @mcmorisi mcmorisi requested review from a team, JamesKovacs and BorisDog and removed request for a team and JamesKovacs April 24, 2025 18:57
    Copy link
    Collaborator

    @BorisDog BorisDog left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    The new content looks good, few comments about the unchanged content of this page:

    • Strict mode was removed in 3.0, so we should remove it from docs as well (it's marked as deprecated.
    • We should also specify that "relaxed" is the default mode now.
    • Should "Relaxed mode" be just "Relaxed"? As technically every entry in that table is a "mode".

    Also we need to update this page, as C# supports Canonical and Relaxed modes now. Does it need a separate ticket?

    @mcmorisi mcmorisi requested a review from BorisDog April 29, 2025 19:35
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants