-
Notifications
You must be signed in to change notification settings - Fork 24
DOCSP-49078: Extended JSON #619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: docsp-45382-comp-cvg
Are you sure you want to change the base?
DOCSP-49078: Extended JSON #619
Conversation
✅ Deploy Preview for docs-csharp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "Overview" and "Extended JSON Formats" sections seem like good candidates for the docs-shared
repo:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new content looks good, few comments about the unchanged content of this page:
- Strict mode was removed in 3.0, so we should remove it from docs as well (it's marked as deprecated.
- We should also specify that "relaxed" is the default mode now.
- Should "Relaxed mode" be just "Relaxed"? As technically every entry in that table is a "mode".
Also we need to update this page, as C# supports Canonical and Relaxed modes now. Does it need a separate ticket?
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-49078
Staging Links
Self-Review Checklist